Bug: reading two lines as one#53
Merged
nacholibre merged 3 commits intonacholibre:masterfrom Jan 20, 2026
Merged
Conversation
If the chunk size matches the end of the line, then the two lines are read as one
Owner
|
@Pavel-Ryabov thanks for your contribution. It seems some of the test fail after your change. Can you take a look? Thanks. |
Contributor
Author
|
Sorry. I used node tests for the first time and didn't notice that not all tests were passing. |
Owner
|
@Pavel-Ryabov Thanks for your contribution. I'll merge and make a new minor release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the chunk size matches the end of the line, then the two lines are read as one.
Added test and my fix