Fix: Discarded-qualifiers errors in string searching functions#531
Merged
nook24 merged 1 commit intonaemon:masterfrom Mar 31, 2026
Merged
Fix: Discarded-qualifiers errors in string searching functions#531nook24 merged 1 commit intonaemon:masterfrom
nook24 merged 1 commit intonaemon:masterfrom
Conversation
Currently Naemon uses a mix of (char *) and (const char *) as input for different string functions such as strpbrk() or strchr(). Modern compilers and stricter build flags (-Werror) throw errors when the result of string searching functions like strpbrk() or strchr() is assigned to a non-const pointer, especially when the input was cast to const char*. This commit adds explicit (char *) casts to the return values of strpbrk and strchr to ensure compatibility across different compiler versions and to satisfy -Werror=discarded-qualifiers. Affected functions: - strpbrk - strchr Issues: - naemon#530 - naemon#522 Signed-off-by: nook24 <info@nook24.eu>
Closed
merdely
approved these changes
Mar 29, 2026
merdely
left a comment
merdely
left a comment
There was a problem hiding this comment.
This fixed the build for me! Thank you!
sni
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently Naemon uses a mix of (char *) and (const char *) as input for different string functions such as strpbrk() or strchr(). Modern compilers and stricter build flags (-Werror) throw errors when the result of string searching functions like strpbrk() or strchr() is assigned to a non-const pointer, especially when the input was cast to const char*.
This commit adds explicit (char *) casts to the return values of strpbrk and strchr to ensure compatibility across different compiler versions and to satisfy -Werror=discarded-qualifiers.
Affected functions:
Issues: