fix: resolve all go-review issues (CRITICAL/HIGH/MEDIUM)#21
Merged
Conversation
CRITICAL: - portchecker: handle SetDeadline/Write errors in checkUDP to prevent goroutine leak - traceroute: check SetControlMessage error on IPv6 send socket (non-fatal) HIGH: - mping: protect portChecker with pMu mutex to eliminate data race across goroutines - mping: create real doneCh when cfg.count > 0 so TUI shows "Finished" footer - mping: use errors.Is for pflag.ErrHelp comparison - ui: replace 16-parameter Run() with RunOptions struct - mping/traceroute: wrap errors with context in socket open paths and getInterfaceIP MEDIUM: - pinger: replace raw sync/atomic usage with atomic.Uint32 for traceCounter - pinger/portchecker: use errors.As instead of direct type assertions for net.Error - tui_helpers: return false (not silent zero) on ParseFloat error in filter - tui_helpers: appendErrorLog uses incremental fmt.Fprintf (O(1)) instead of O(n) join on every call - pinger: add godoc to NewPinger, NewPingerWithOptions, Reply
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CRITICAL:
HIGH:
MEDIUM: