Fix/go review issues#22
Merged
Merged
Conversation
…pinger.go
- Fix mis-indented `if errors.As` block inside `runReceiver` (gofmt violation
introduced when migrating from type assertion to errors.As)
- Replace empty non-fatal error blocks `{ // Non-fatal }` with `{ _ = err }` to
match the style used in traceroute.go; `go vet` reports empty error branches
as suspicious in some lint configurations
- Run gofmt -w to fix pre-existing alignment issues in const block and struct
field alignment in receiverConfig / receiverV4Config / receiverV6Config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.