Bump github.com/arttor/helmify from 0.4.18 to 0.4.19#638
Bump github.com/arttor/helmify from 0.4.18 to 0.4.19#638dependabot[bot] wants to merge 2 commits intomainfrom
Conversation
dependabot
Bot
added
dependencies
|
On hold due to arttor/helmify#175 and arttor/helmify#188 |
dependabot
Bot
force-pushed
the
dependabot/go_modules/github.com/arttor/helmify-0.4.19
branch
from
174706c to
43607bf
Compare
dependabot
Bot
force-pushed
the
dependabot/go_modules/github.com/arttor/helmify-0.4.19
branch
2 times, most recently
from
28dee08 to
5e24616
Compare
Bumps [github.com/arttor/helmify](https://github.com/arttor/helmify) from 0.4.18 to 0.4.19. - [Release notes](https://github.com/arttor/helmify/releases) - [Commits](arttor/helmify@v0.4.18...v0.4.19) --- updated-dependencies: - dependency-name: github.com/arttor/helmify dependency-version: 0.4.19 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/go_modules/github.com/arttor/helmify-0.4.19
branch
from
5e24616 to
b2be2bd
Compare
There was a problem hiding this comment.
Pull request overview
This is a Dependabot-generated PR that bumps the github.com/arttor/helmify dependency from version 0.4.18 to 0.4.19. The helmify tool is used in this project to generate Helm charts from Kustomize configurations. According to the release notes, version 0.4.19 adds support for nodeSelector, tolerations, and topologySpreadConstraints fields in values.yaml, and includes a fix to backport the serviceAccount manifest from helm.sh defaults.
Changes:
- Updated helmify dependency version in go.mod from 0.4.18 to 0.4.19
- Updated corresponding checksums in go.sum
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| go.mod | Updated helmify dependency version to 0.4.19 with outdated/contradictory comment |
| go.sum | Updated checksums for the new helmify version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| github.com/alexkohler/prealloc v1.0.0 // indirect | ||
| github.com/alingse/asasalint v0.0.11 // indirect | ||
| github.com/arttor/helmify v0.4.18 // pinned: 0.4.19 breaks ServiceAccount naming (see https://github.com/arttor/helmify/commit/85f89d48) | ||
| github.com/arttor/helmify v0.4.19 // pinned: 0.4.19 breaks ServiceAccount naming (see https://github.com/arttor/helmify/commit/85f89d48) |
There was a problem hiding this comment.
The comment states "pinned: 0.4.19 breaks ServiceAccount naming" but this PR is upgrading TO version 0.4.19, which is contradictory. According to the release notes for v0.4.19, commit b975e66 includes "fix: backport serviceAccount manifest from helm.sh default", suggesting that 0.4.19 actually fixes ServiceAccount issues rather than breaks them. Either the comment should be updated to reflect that this version actually fixes the issue, or if 0.4.19 truly breaks ServiceAccount naming, this upgrade should not proceed.
Bumps github.com/arttor/helmify from 0.4.18 to 0.4.19.
Release notes
Sourced from github.com/arttor/helmify's releases.
Commits
4f6d16bfix: examples6b7c018fix: linterb975e66fix: backport serviceAccount manifest from helm.sh default85f89d4feat: add missing fields to valuesYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)