implementing ASM window#222
Merged
Merged
Conversation
LinArcX
force-pushed
the
implementingAsmWindow
branch
from
5132bb5 to
9fc4402
Compare
nakst
requested changes
Jun 9, 2026
| for (char *p = evaluateResult; p < current; p++) { | ||
| if (*p == '\n') line++; | ||
| } | ||
| asmCode->vScroll->position = line * lineHeight - (viewHeight / 2); |
Contributor
Author
There was a problem hiding this comment.
Hi, i tried, but it didn't work. (vScroll position is always at the bottom of the ASM window)
| } | ||
|
|
||
| void ASMWindowUpdate(const char *data, UIElement *element) | ||
| { |
Owner
There was a problem hiding this comment.
Sorry to nitpick but in our coding styling the { goes on the above line.
Owner
|
Thank you for the commit! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR gives you the ability to see assembly instructions in a separate window, while you're debugging your source code in the main window: