Add Makefile, currently for Linux and OpenIndiana/Illumos#226
Open
mebenn wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need a makefile for OpenIndiana, so I added one. Currently only for both Linux and OpenIndiana, I didn't get time for the other *BSDs, but I can finish if anyone is interested. Just llet me know; but I might require some help as I'm not going to install a load of BSDs, so for each OS a tester would be good (except for Linux and OpenIndiana which I've already quickly tested).
Using the current scripts on a build server, i.e., Jenkins, is not ideal. If the admin has to make a small change and kicks-off the build again for the entire system and a load of packages start to rebuild from scratch is not ideal for the admin.
I've also noticed that some users want to install GDB if it isn't already installed in a build script! Don't do that; if someone wants, for example, to extend the makefile and shoots off a build script on some *BSD just to check, and each time a GDB gets installed, although I just would like to build!!! Installing GDB if it hasn't already been installed is the responsibility of a package manager. gf2 should be made to have a dependency on GDB
Remember the Unix Moto: Do one thing and do it well!
build.sh should only build.
If you'd like GDB to be installed, then add a new script build_and_install_gdb, or whatever; or when you start gf2, issue a warning: GDB not installed....and possibley exit.
The code in the Makefille needs some clean up: I've got a load of repeated code for the various operating systems; so as soon as I get time I'll update, assuming people are interested.
Idea: if you'd like to keep the scripts, it might be better to use only one script. The master script should detect the OS (and not the poor user) and call the appropriate script. Interested or why bother?
What about automaticaly compiling the extensions as standard? Is there a reason against doing somethingh like this?