chore: migrate package manager to bun#741
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5024ca1730
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| tty: true | ||
| restart: unless-stopped | ||
| command: sh -c "corepack enable && pnpm install --frozen-lockfile=false && cd apps/web && node scripts/check-dev-db.mjs && pnpm exec next dev --webpack --hostname 0.0.0.0" | ||
| command: sh -c "npm install --global bun@1.3.14 && bun install --frozen-lockfile=false && cd apps/web && node scripts/check-dev-db.mjs && ../../node_modules/.bin/next dev --webpack --hostname 0.0.0.0 --port $${PORT:-7015}" |
There was a problem hiding this comment.
Use a valid Bun install invocation in compose
When the compose web service starts, this command always reaches bun install --frozen-lockfile=false. Bun's install help lists --frozen-lockfile as a valueless flag (Disallow changes to lockfile), and running the same invocation exits with The argument '--frozen-lockfile' does not take a value, so docker compose -f docker-compose.dev.yml up will keep restarting the web container before Next starts. Use bun install or another supported Bun flag combination here.
Useful? React with 👍 / 👎.
|
Controller disposition for current head Verified:
Blocker: I could not independently reproduce the required Docker builds from this controller environment because |
|
Controller refresh for current head Fresh evidence:
Next: rebase/rebuild the package-manager migration on current |
Summary
Verification