Skip to content

Use include_bipm argument when loading Fermi TOAs with weights#1977

Open
coclar wants to merge 2 commits intonanograv:masterfrom
coclar:fermi_bipm_fix
Open

Use include_bipm argument when loading Fermi TOAs with weights#1977
coclar wants to merge 2 commits intonanograv:masterfrom
coclar:fermi_bipm_fix

Conversation

@coclar
Copy link
Copy Markdown
Contributor

@coclar coclar commented Mar 28, 2026

Fixes a bug where the include_bipm argument was hard-coded to False when loading Fermi TOAs with weights.

@dlakaplan
Copy link
Copy Markdown
Contributor

This looks fine to merge, but could you add an entry to CHANGELOG-unreleased?

@coclar
Copy link
Copy Markdown
Contributor Author

coclar commented Apr 7, 2026

Thanks @dlakaplan, I've added the note to the changelog.

@dlakaplan
Copy link
Copy Markdown
Contributor

Actually, should fermiphase also deal with this argument?

https://github.com/nanograv/PINT/blob/master/src/pint/scripts/fermiphase.py#L122:

# For Fermi, we are not including GPS or TT(BIPM) corrections
    ts = get_Fermi_TOAs(
        args.eventfile,
        maxmjd=maxmjd,
        minmjd=minmjd,
        weightcolumn=args.weightcol,
        targetcoord=tc,
        planets=args.planets,
        ephem=args.ephem,
    )

so maybe add it to the command-line options and then pass to the function? Or is that not needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants