Introduce experimental BasisCommonGP2 and FourierBasisCommonGP2 that accept selections#290
Open
vallis wants to merge 8 commits intonanograv:devfrom
Open
Introduce experimental BasisCommonGP2 and FourierBasisCommonGP2 that accept selections#290vallis wants to merge 8 commits intonanograv:devfrom
vallis wants to merge 8 commits intonanograv:devfrom
Conversation
added 4 commits
August 30, 2021 11:22
FourierBasisCommonGP and BasisCommonGP2 that support selections (e.g., to have separate common monopole GPs by telescope). These require specifying Tspan manually.
Codecov Report
@@ Coverage Diff @@
## master #290 +/- ##
==========================================
+ Coverage 88.05% 88.41% +0.35%
==========================================
Files 13 13
Lines 2980 3055 +75
==========================================
+ Hits 2624 2701 +77
+ Misses 356 354 -2
Continue to review full report at Codecov.
|
Member
|
Hi @vallis , is this PR ready for review? I can properly look at it this week. |
Member
|
One question: is this a separate class instead of just updating BasisCommonGP, because this is experimental? Ideally the selections would just work for the regular common Common GP classes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For instance, to implement independent correlated GPs on each telescope, one could do
Note that it is currently necessary to set
Tspan.The PR also adds the method
telescope()to pulsar, andby_telescope()to selections.