Skip to content

fix-redshift-minus-one-lib_tools-gravwaves #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kayhangultekin merged 2 commits into from
Apr 21, 2026
+5 −1
Merged

fix-redshift-minus-one-lib_tools-gravwaves #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50a2bdc
fix-redshift-minus-one-lib_tools-gravwaves
shreyas-tiruvaskar Jan 8, 2026
a0ae1d0
Merge branch 'main' into fix-redshift-minus-one-lib_tools-gravwaves
shreyas-tiruvaskar Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion holodeck/gravwaves.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -719,7 +719,9 @@ def char_strain_sq_from_bin_edges_redz(edges, redz):

# convert from observer-frame to rest-frame; still using frequency-bin centers
fr = utils.frst_from_fobs(fc[np.newaxis, np.newaxis, np.newaxis, :], redz)

# redz is set to -np.inf instead of -1, which makes fr negative and creates a nan error in hs calculation
# so, to avoid nan, setting those fr to zero
fr[fr<0] = 0.0
hs = utils.gw_strain_source(mc, dc, fr)
hc2 = (hs ** 2) * (fc / df)
return hc2
Expand Down
2 changes: 2 additions & 0 deletions holodeck/librarian/lib_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -836,6 +836,8 @@ def run_model(
data['hc_bg'] = hc_bg

if gwb_flag:
negative_mask = use_redz < 0.0 # galaxy mergers that stall
use_redz[negative_mask] = -np.inf # set to -inf so they can't contribute to GWB
gwb = holo.gravwaves._gws_from_number_grid_integrated_redz(edges, use_redz, number, nreals)
data['gwb'] = gwb

Expand Down
Loading