Conversation
sbaluja
reviewed
Jun 25, 2026
sbaluja
reviewed
Jun 25, 2026
sbaluja
reviewed
Jun 25, 2026
sbaluja
reviewed
Jun 25, 2026
sbaluja
reviewed
Jun 25, 2026
sbaluja
reviewed
Jun 25, 2026
sbiscigl
reviewed
Jun 26, 2026
sbiscigl
reviewed
Jun 30, 2026
sbiscigl
reviewed
Jul 6, 2026
| * Acquire() inside the callback to obtain a new owning wrapper that | ||
| * keeps the buffer valid until the new wrapper is destroyed. | ||
| */ | ||
| class AWS_CRT_CPP_API S3BufferTicket final |
There was a problem hiding this comment.
can we make it a separate header?
Owner
Author
There was a problem hiding this comment.
Is there a specific reason you'd want S3BufferTicket in a separate header? Just curious as to the motivation but happy to split it out.
sbaluja
reviewed
Jul 7, 2026
sbaluja
reviewed
Jul 7, 2026
sbaluja
reviewed
Jul 7, 2026
sbaluja
reviewed
Jul 7, 2026
sbaluja
reviewed
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Crt Bindings for TM 2.0
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.