refactor: use environment variables for Docker Compose credentials#4210
refactor: use environment variables for Docker Compose credentials#4210RinZ27 wants to merge 1 commit intonasa:masterfrom
Conversation
f004996 to
ab3393f
Compare
Jkovarik
left a comment
There was a problem hiding this comment.
Hi there - thanks for your contribution!
Please remove the extraneous/unrelated edits/endlines/etc from the PR so we can review it effectively.
Removing objection as this is a CI update in progress. |
Change was due to CI updates in progress
|
Thanks for the review, @Jkovarik. I totally hear you on the extraneous edits—I'll be much tighter with the diffs in future PRs to keep the reviews focused. Since I'm refactoring these CI credentials to use env vars, I'll make sure any follow-up commits stay strictly within that scope. Glad we're on the same page regarding the CI hardening. I'll keep an eye out for any further feedback! |
d05b544 to
bf0f237
Compare
|
I've just cleaned up the PR to remove all the extraneous noise as requested—should be just the Docker security fix now. I also included a minimal |
bf0f237 to
96bc38c
Compare
78f1343 to
e21467d
Compare
f87d2e6 to
6464bdc
Compare
6464bdc to
fb50ff9
Compare
Refactored the
bamboo/docker-compose.ymlto replace hardcoded credentials with environment variable references. While these services are primarily used for testing, avoiding hardcoded passwords likepasswordortestpassis a prudent security measure.Changes
POSTGRES_PASSWORDto use${POSTGRES_PASSWORD:-password}.FTP_PASSWORDto use${FTP_PASSWORD:-testpass}andFTP_USERto use${FTP_USER:-testuser}.This approach maintains backward compatibility for local testing while enabling secure credential injection in more sensitive environments. It reduces the risk of default credentials being accidentally propagated into production-like setups.
Proof of Concept:
Unauthorized access to the Postgres or FTP containers would be trivial if they were exposed with these default settings. Transitioning to environment variables reinforces the principle of secure-by-default configuration.