Skip to content

refactor(FileDownlink): unify cancel path and handle COOLDOWN returns#5369

Open
Abhishek21g wants to merge 1 commit into
nasa:develfrom
Abhishek21g:abhishek/filedownlink-v4-cleanup
Open

refactor(FileDownlink): unify cancel path and handle COOLDOWN returns#5369
Abhishek21g wants to merge 1 commit into
nasa:develfrom
Abhishek21g:abhishek/filedownlink-v4-cleanup

Conversation

@Abhishek21g

@Abhishek21g Abhishek21g commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Summary

Follow-up to @nathancheek's discussion on #5347 and future work from #5288.

Testing

Svc_FileDownlink_ut_exe: 7/7 pass.

Related #5347 #5288

@Abhishek21g
refactor(FileDownlink): unify cancel path and handle COOLDOWN returns
1e6a207 
Route cancel packets through sendFilePacket() and a single outbound
buffer instead of a separate CANCEL_PACKET memory store. Ignore buffer
returns during COOLDOWN (v4 follow-up to nasa#5288). Fixes nasa#5347 via the
shared send path. Remove unused m_timeout on devel.
@Abhishek21g Abhishek21g force-pushed the abhishek/filedownlink-v4-cleanup branch from 54a5c09 to 1e6a207 Compare July 8, 2026 16:49
@Abhishek21g

Abhishek21g commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

Rebased onto latest devel. @nathancheek — this implements the unified cancel path through sendFilePacket() and COOLDOWN buffer-return handling from your #5347 / #5288 follow-up.

@Abhishek21g Abhishek21g mentioned this pull request Jul 13, 2026
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FileDownlink cancel packet buffer is set to wrong size

1 participant

@Abhishek21g