Conversation
Add filter at query level to exclude runs where pull contains 'manual' (e.g. 22999633670_manual_attempt_1) in: - flaky_tests_history.py: when building flaky_tests_window from test_results - get_muted_tests.py: in get_all_tests for both job_id and branch modes - upload_testowners.py: when populating testowners from test_runs Co-authored-by: Kirill Rysin <naspirato@users.noreply.github.com>
|
Cursor Agent can help with this pull request. Just |
Add filter to exclude runs where pull contains 'manual'. Run-tests job_name was already excluded. Co-authored-by: Kirill Rysin <naspirato@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog entry
Exclude manual workflow runs from test status aggregation in
update_muted_tests.Changelog category
Description for reviewers
This change prevents manual workflow runs (e.g.,
workflow_dispatchwith_manual_attempt_Nin thepullfield) from being included in the aggregation of test statuses. This ensures thatupdate_muted_testsandcreate_issues_for_muted_testsworkflows use more relevant data, excluding potentially skewed results from manual interventions. The filterand (pull IS NULL OR NOT String::Contains(pull, 'manual'))was added to relevant SQL queries.