Skip to content

bugfix: skip hardcoded titleHeight in calc if there is no title or subtitle #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
linusbrolin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bugfix: skip hardcoded titleHeight in calc if there is no title or subtitle #85

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,9 +472,9 @@ class PDFDocumentWithTables extends PDFDocument {
}

// 24.1 is height calc title + subtitle
titleHeight = !lockAddTitles ? 24.1 : 0;
titleHeight = ((title || subtitle) && !lockAddTitles ? 24.1 : 0);
// calc if header + first line fit on last page
const calc = startY + titleHeight + firstLineHeight + this.headerHeight + safelyMarginBottom// * 1.3;
const calc = startY + titleHeight + firstLineHeight + headerHeight + safelyMarginBottom;// * 1.3;

// content is big text (crazy!)
if(firstLineHeight > maxY) {
Expand Down