Skip to content

Comments

feat: allow to pass text features#90

Open
moshfeu wants to merge 3 commits intonatancabral:mainfrom
moshfeu:feat/support-rtl
Open

feat: allow to pass text features#90
moshfeu wants to merge 3 commits intonatancabral:mainfrom
moshfeu:feat/support-rtl

Conversation

@moshfeu
Copy link

@moshfeu moshfeu commented Feb 17, 2024

closes #89

This PR aims to allow users to pass text features to the .text() functions this library uses to render texts
As described in the attached issue, is to apply rtl texts

@moshfeu
Copy link
Author

moshfeu commented Feb 17, 2024

I wondered whether should the options include rtl: true / false and the library just reverse the headers / rows / data arrays
I left it as is and I'm reversing the data in my side but if you think it's better or even needed to do it in the library side, I can create another PR

@Zsl8
Copy link

Zsl8 commented Jul 24, 2024

Thx alot for this i just needed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow to set text features to support rtl

2 participants