Allow --port range for random port selection#5
Open
samrocketman wants to merge 4 commits into
Open
Conversation
This way the tracker listens on a new random port each time herd.py is called. This allows Herd to be integrated into a continuous delivery/continuous deployment environment. With port range socket is tested before port is used. pep8 cleanup on get_random_open_port function compared to Herd patch.
Updated gitignore so that paths created by setup.py commands are ignored.
A random port selection from a port range has moved to being selected at the beginning of runtime.
Within function get_random_open_port(). The socket testing interfered with the actual tracker starting a listener. Since no communication happens over the opened socket, and we're just testing if it is free to bind, there should be no timeout for the socket to expire.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way the tracker listens on a new random port each time
hordeis called. This allows Horde to be integrated into a continuous delivery/continuous deployment environment from the same deploy agent to multiple destination hosts (with different projects). This will allow the deployments to scale well in an automated deployment environment.With port range, the socket is tested before port is used.
This was a cherry pick from russss#14.