Print non scoped signing keys as well as signing keys - #1700
Conversation
Signed-off-by: R.I.Pienaar <rip@devco.net>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4d562991aa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| table = iu.NewTableWriterf(opts(), "Signing Keys") | ||
| table.AddHeaders("Key") | ||
| for _, key := range keys { | ||
| table.AddRow(key) |
There was a problem hiding this comment.
For accounts that have a plain account signing key (for example, imported from nsc), this now exposes that key in auth account keys ls, but the sibling info/rm paths still call SelectSigningKey, which iterates ScopedSigningKeys().List() and dereferences scope.Key() after GetScope returns nil for a non-scoped key (internal/auth/auth.go:278-281). Copying one of these newly listed keys into auth account keys rm --key ... or reaching it through the prompt can therefore panic instead of reporting that the key is unsupported or removing it; skip non-scoped entries in selection or teach those commands to handle them.
Useful? React with 👍 / 👎.
1 participant
No description provided.