Assignment Complete - #4
Open
ghostgator wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
While this loop seems to work for the tests I have created, I am not sure it's absolutely correct. I think it's probably best to check for an exponent token and then call both the shift_tokens and parse_factor. It should be up to the parse_base call to check for integer, decimal, or the left parenthesis.
|
Overall, a very good job. You managed to pass the test suite, but it is incomplete. If you write tests that find the errors in your code (and you correct the code), I'd be happy to give you a bit of extra credit for the parser bit. Lexer: 40/40 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All lexer and parser tests pass successfully at this time.