FEATURE: Add CompletableFuture BTree position APIs#1064
Merged
jhpark816 merged 1 commit intonaver:developfrom Apr 2, 2026
Merged
FEATURE: Add CompletableFuture BTree position APIs#1064jhpark816 merged 1 commit intonaver:developfrom
jhpark816 merged 1 commit intonaver:developfrom
Conversation
bbfc75c to
21ae673
Compare
oliviarla
reviewed
Mar 26, 2026
src/main/java/net/spy/memcached/collection/BTreeFindPosition.java
Outdated
Show resolved
Hide resolved
src/main/java/net/spy/memcached/collection/BTreeFindPosition.java
Outdated
Show resolved
Hide resolved
src/test/java/net/spy/memcached/v2/BTreeAsyncArcusCommandsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/net/spy/memcached/v2/BTreeAsyncArcusCommandsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/net/spy/memcached/v2/BTreeAsyncArcusCommandsTest.java
Outdated
Show resolved
Hide resolved
f345e0c to
aada6a8
Compare
oliviarla
previously approved these changes
Mar 27, 2026
aada6a8 to
e1fb280
Compare
e1fb280 to
6dfcecf
Compare
Collaborator
Author
의견 정리 및 구현 방향1. bopGetByPosition (범위 조회)
2. bopPositionWithGet
|
Collaborator
|
@oliviarla 리뷰가 끝났나요? |
Collaborator
|
@f1v3-dev 새로운 반환 타입 구현이 반영된 상태라면, 셀프 리뷰 한번 먼저 해주세요. |
3282764 to
c00aae8
Compare
Collaborator
Author
|
셀프 리뷰 진행하였습니다. 리뷰 부탁드립니다! |
oliviarla
reviewed
Apr 1, 2026
src/main/java/net/spy/memcached/collection/BTreeFindPosition.java
Outdated
Show resolved
Hide resolved
src/main/java/net/spy/memcached/v2/vo/BTreePositionElement.java
Outdated
Show resolved
Hide resolved
c00aae8 to
11ef0d9
Compare
oliviarla
reviewed
Apr 1, 2026
src/test/java/net/spy/memcached/v2/BTreeAsyncArcusCommandsTest.java
Outdated
Show resolved
Hide resolved
e423acb to
9c37573
Compare
oliviarla
reviewed
Apr 2, 2026
9c37573 to
266db90
Compare
266db90 to
1d3310d
Compare
oliviarla
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
⌨️ What I did
BTree Position 조회 API 추가
bopGetPosition: bKey가 일치하는 element의 position 반환bopGetByPosition (gbp): 단건 - position에 맞는 element 반환 / 범위 - 범위 내의Map<position, BTreeElement>반환bopPositionWithGet (pwg): 주어진 bKey의 position을 찾고, 해당 position 양쪽으로 count 개씩 인접 element를 함께 반환작업 특이사항
as-is
BTreeFindPosition,BTreeFindPositionWithGet은 bKey를 long 또는 byte[] 형태로만 받는 생성자만 존재to-be
BTreeFindPosition: String 생성자 추가 →bopGetPosition에서 bKey.toString() 값을 그대로 전달BTreeFindPositionWithGet: BKeyObject를 받는 생성자 추가 + 기존 long/byte[] 생성자는 이를 위임하도록 체이닝BKey: toBKeyObject() 변환 메서드 추가