FEATURE: Add CompletableFuture Map APIs#1072
Open
f1v3-dev wants to merge 1 commit intonaver:developfrom
Open
Conversation
37a26e4 to
68254f7
Compare
oliviarla
previously approved these changes
Apr 1, 2026
jhpark816
reviewed
Apr 1, 2026
| public ArcusFuture<Boolean> mopDelete(String key, List<String> mKeys, boolean dropIfEmpty) { | ||
| MapDelete delete = new MapDelete(mKeys, dropIfEmpty, false); | ||
| return collectionDelete(key, delete); | ||
| } |
Collaborator
There was a problem hiding this comment.
mopDelete 연산처럼
mopGet 연산도 다른 mopGet 메소드를 호출하면 되지 않는 지 ?
mkeys 인자가 없는 메소드에서
new ArrayList<>()를 mkeys 인자로 하여 mopGet 호출하면 되지 않는 지?
1개의 mkey 인자인 경우는 리턴 값이 다른 경우인 데,
이 경우에는 어떻게 하면 되는 지?
Collaborator
Author
There was a problem hiding this comment.
1. 모든 Map 조회 (mkeys 인자가 없는 메서드)
mopDelete와 동일한 패턴으로 구현할 수 있어서 아래와 같이 변경하도록 하겠습니다.
public ArcusFuture<Map<String, T>> mopGet(String key, GetArgs args) {
return mopGet(key, new ArrayList<>(), args);
}2. 단건 조회 (1개의 mKey)
리턴 값이 다를 뿐만 아니라 응답(ERR_NOT_FOUND_ELEMENT)에 대한 처리가 다건 조회(List<String> mKeys)와 다르기 때문에 별도로 구현을 해야합니다.
| 응답 상태 | 단건 (ArcusFuture<T>) |
다건 (ArcusFuture<Map<String, T>>) |
|---|---|---|
SUCCESS |
T |
Map<String, T> |
ERR_NOT_FOUND_ELEMENT |
null |
{} (빈 맵) |
ERR_NOT_FOUND |
null |
null |
jhpark816
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
⌨️ What I did
mopCreate,mopInsert,mopUpsert,mopUpdate,mopGet,mopDelete메서드를 구현합니다.