A rule that rejects obvious words in the commit title#67
Open
tehraninasab wants to merge 4 commits intonblockchain:masterfrom
Open
A rule that rejects obvious words in the commit title#67tehraninasab wants to merge 4 commits intonblockchain:masterfrom
tehraninasab wants to merge 4 commits intonblockchain:masterfrom
Conversation
Member
|
Let's consider the commitlint PR for fixing subject-full-stop highest priority, but after you've tackled that, you can address the feedback that I'm going to share about this PR. |
knocte
reviewed
Feb 8, 2023
tehraninasab
force-pushed
the
rejectObviousWords-squashed-and-rebased
branch
2 times, most recently
from
977d10f to
fbbab03
Compare
tehraninasab
force-pushed
the
rejectObviousWords-squashed-and-rebased
branch
5 times, most recently
from
62e1a2d to
67e2ddf
Compare
Member
|
Please add a new failing test with this commit message: tehraninasab@006fe22 That is, if the subject contains just the word "fix", and there's no commit msg body, this rule should complain as well. |
tehraninasab
force-pushed
the
rejectObviousWords-squashed-and-rebased
branch
4 times, most recently
from
58c2093 to
dc8d7a2
Compare
Contributor
Author
Done |
knocte
force-pushed
the
master
branch
2 times, most recently
from
d1bd1c2 to
908c11d
Compare
knocte
force-pushed
the
master
branch
2 times, most recently
from
c5fb9d5 to
18898b7
Compare
Add tests for reject-obvious-words rule.
Add a rule to reject obvious words in the commit title.
If the subject contains just the word "fix", and there's no commit msg body, this rule should complain.
tehraninasab
force-pushed
the
rejectObviousWords-squashed-and-rebased
branch
from
dc8d7a2 to
7c678a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced #15