Skip to content

Detect missing the --version flag in dotnet tool install foo invocations#89

Merged
knocte merged 5 commits intonblockchain:masterfrom
tehraninasab:unpinnedDotnetToolInstallVersions-squashed
May 23, 2023
Merged

Detect missing the --version flag in dotnet tool install foo invocations#89
knocte merged 5 commits intonblockchain:masterfrom
tehraninasab:unpinnedDotnetToolInstallVersions-squashed

Conversation

@tehraninasab
Copy link
Contributor

No description provided.

@knocte
Copy link
Member

knocte commented Mar 28, 2023

Please rebase this PR 🙏 Thanks

Failing test for
DetectUnpinnedVersionsInGitHubCI
function.
Implement
DetectUnpinnedDotnetToolInstallVersions
function.
Run unpinnedDotnetToolInstallVersions.fsx script.
@tehraninasab tehraninasab force-pushed the unpinnedDotnetToolInstallVersions-squashed branch from a6ec0df to 92d99ed Compare March 28, 2023 10:27
@tehraninasab
Copy link
Contributor Author

Please rebase this PR pray Thanks

Done

@knocte knocte merged commit 1da28c8 into nblockchain:master May 23, 2023
@knocte
Copy link
Member

knocte commented May 23, 2023

@realmarv sorry I realised there were a couple of issues in this PR after I merged it, so please can you create a new PR that addresses them? I'm gonna point them out now.

@tehraninasab
Copy link
Contributor Author

@realmarv sorry I realised there were a couple of issues in this PR after I merged it, so please can you create a new PR that addresses them? I'm gonna point them out now.

Here is the new PR: #110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants