Added an initial default.nix that can build webdriver-w3c. - #62
Open
seanparsons wants to merge 1 commit into
Open
Added an initial default.nix that can build webdriver-w3c.#62seanparsons wants to merge 1 commit into
seanparsons wants to merge 1 commit into
Conversation
Owner
|
Thank you for making this PR! I don't know much about Nix and this will be a good excuse to learn. Leaving a note for my future self: look into splitting up the test suites to isolate the ones that make nix cranky. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very early cut of a file that'll get webdriver-w3c to be built via nix, so it can be built with just
nix-build .in the root of the project and it'll do all the heavy lifting.The only particularly unusual thing is the
dontCheckwrapper aroundscript-monadandwebdriver-w3cwhich just prevents their test suites from being built and run. Forscript-monadthis is because it attempts to make a network call which nix prevents so that builds can't break the reproducibility of the build. Similarly thewebdriver-w3ctest suite relies on instances of geckodriver and chromedriver. Both of those projects could do with a build flag that disable any tests which rely on those and then eventually get these packages flagged as good in nixpkgs with that flag set.