Make widgetToImage() require a size parameter, fix example app to supply size, fixes #18#19
Open
timmaffett wants to merge 2 commits intonbrucker:mainfrom
Open
Make widgetToImage() require a size parameter, fix example app to supply size, fixes #18#19timmaffett wants to merge 2 commits intonbrucker:mainfrom
timmaffett wants to merge 2 commits intonbrucker:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
widgetToImage()require a size parameter. The default ofSize(double.maxFinite, double.maxFinite)prevents it from returning anything but a blank image and making it appear that the function does not work. That is clearly not a good default.Also fix the example to supply a size parameter for it's
widgetToImage()demonstration so that it now actually demonstrates that this function works instead of just showing a blank result.