Add AoA and range calibration pipeline and UI support#60
Add AoA and range calibration pipeline and UI support#60nbschultz97 wants to merge 1 commit intomainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| self._range_measurements[dist] = rssi | ||
| self._append("CAL", f"{dist:.1f} m median RSSI: {rssi:.2f} dBm") | ||
| self._range_chip_var.set("") | ||
| self.range_chip_label.grid_remove() | ||
| self._update_range_progress() |
There was a problem hiding this comment.
When recording a range point the code calls self._range_chip_var.set(""), but the only variable created in __init__ is range_chip_var. Pressing “Record” (and similarly “Reset”, which makes the same call) will raise an AttributeError instead of updating the calibration chip indicator, halting the range calibration workflow.
Useful? React with 👍 / 👎.
1 participant
Summary
Testing
Codex Task