Skip to content

no mp when parallel is false, also ruff#2

Open
corinwagen wants to merge 1 commit into
ncasetti7:masterfrom
corinwagen:feature/no_mp_when_parallel_false
Open

no mp when parallel is false, also ruff#2
corinwagen wants to merge 1 commit into
ncasetti7:masterfrom
corinwagen:feature/no_mp_when_parallel_false

Conversation

@corinwagen

Copy link
Copy Markdown

I added code to avoid using multiprocessing when parallel=False, as I was getting pickling errors. I think this may be OS-dependent; multiprocessing's default process spawn method switches between spawn and fork depending on the operating system used, which is messy. (This also avoids the mp.Process startup time, which can be substantial.)

I also ran the code through the ruff formatter / linter automatically through nvim—no need to merge these, happy to pull out the formatting changes.

The test suite passes locally except for the multiprocessing tests, which are still giving the the aforementioned error:

FAILED tests/test_multiproc.py::test_parallel_run_proc_single_worker - AttributeError: Can't pickle local object 'test_parallel_run_proc_single_worker.<locals>.wrapper'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant