fix: incorrect line length detection if markup contained html entities, unexpected spaces#10
Merged
Merged
Conversation
…s, unexpected spaces
if the formatted text contained html entities like `<` and `>` they would be counted
as 4 characters even though those are later replaced with `<` and `>` characters respectively.
this fixes that by performing replacement earlier, before length detection happens.
Input:
```html
<frame width="12"> <!> </frame>
```
Old output:
```
┌──────────┐
│<!> │
└──────────┘
```
New Output:
```
┌──────────┐
│<!> │
└──────────┘
```
in some cases when an empty inline tag was followed by a whitespace followed by a non empty inline tag
starting with whitespace, that line after formatting would start with a single whitespace.
Input:
```html
<span>
<line>First Line</line>
<span><span>
<span>
<line>Second Line</line>
</span>
</span>
```
Old Output:
```
First Line
Second Line
```
New Output:
```
First Line
Second Line
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if the formatted text contained html entities like
<and>they would be counted as 4 characters even though those are later replaced with<and>characters respectively.this fixes that by performing replacement earlier, before length detection happens.
Input:
Old output:
New Output:
in some cases when an empty inline tag was followed by a whitespace followed by a non empty inline tag starting with whitespace, that line after formatting would start with a single whitespace.
Input:
Old Output:
New Output: