fix: Update vendor lookup method and dependency for Debian packaging#5
fix: Update vendor lookup method and dependency for Debian packaging#5aquilamacedo wants to merge 1 commit intondejong:masterfrom
Conversation
Replaced 'import OuiLookup' with 'from ouilookup import OuiLookup' due to compatibility issues with ouilookup 0.3.1. This change ensures the project works correctly. Additionally, introduced 'ieee-data' for CSV access, enabling the software to function independently of the ouilookup package, crucial for Debian packaging. Signed-off-by: Aquila Macedo <aquilamacedo@riseup.net>
|
Hi @ndejong, I hope you're doing well! I've been diligently working on packaging arpwitch for Debian and wanted to provide an update on the recent developments. In the process, I encountered a hiccup regarding the ouilookup package, which isn't packaged in Debian. To ensure arpwitch's functionality within the Debian environment, I've implemented a crucial change by introducing a dependency on ieee-data. This addition is aimed at circumventing the unavailability of the ouilookup package and enabling arpwitch to seamlessly access the necessary CSV data from ieee-data. These changes are pivotal to arpwitch's successful integration into the Debian ecosystem. |
|
Hi @aquilamacedo thanks for the PR. Arpwitch does need some love to get it up-to-scratch before being Debian package repo worthy in my opinion. I'm not super excited about the hard-coding of this in your PR oui_path = "/usr/share/ieee-data/oui.csv"Give me a few days (or more) to rework Arpwitch, among other things it needs some async worker magic to keep up with traffic. I'd still value your assistance and efforts in packaging for Debian though - perhaps we can pick that up as an issue - https://github.com/ndejong/arpwitch/issues |
|
Hi @ndejong. Nice, I'll keep an eye out for any updates on the Arpwitch rework.. If there's anything I can do to lend a hand, just let me know. I'm here and ready to help however I can :) |
Replaced
import OuiLookupwithfrom ouilookup import OuiLookupdue to compatibility issues with ouilookup 0.3.1. This change ensures the project works correctly.Additionally, introduced
ieee-datafor CSV access, enabling the software to function independently of the ouilookup package, crucial for Debian packaging.