Skip to content

[filetests]: add arithmetics to zk-runtest#249

Open
MCJOHN974 wants to merge 6 commits into
viktar/test-results-printingfrom
viktar/adding-tests
Open

[filetests]: add arithmetics to zk-runtest#249
MCJOHN974 wants to merge 6 commits into
viktar/test-results-printingfrom
viktar/adding-tests

Conversation

@MCJOHN974
Copy link
Copy Markdown

Here I will add cranelift tests to our zk-filetest pipeline and try to find if something is broken

@MCJOHN974
Copy link
Copy Markdown
Author

Aaaaaaaaaaand, here we are, I copied all tests from arithmetic.clif to zk-arithmetic.clif, except lower bit types which are not related to zk. And, it works, nothing failed on side of test infra, only known bug about signed division (and we can see here how test results are printed in case of fail, thanks for it)

@MCJOHN974
Copy link
Copy Markdown
Author

MCJOHN974 commented Mar 14, 2024

Aaaaaaaaaand, first benefit from new test infra. Our i32 bnot doesn't work. Or we knew this before?? TODO: filetests don't have a lot of tests for bitops. Should we copy wasm spectest here?

upd: I guess it was a known thing

@MCJOHN974
Copy link
Copy Markdown
Author

Srem don't work as well

@MCJOHN974
Copy link
Copy Markdown
Author

Signed right shift is not implemented yet, so didn't add tests for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant