Add placeholder landing page for Nebari Chat Pack#122
Merged
Conversation
Set up an empty documentation structure using Docusaurus 3.5.2 with the Nebari website theme. Only a placeholder landing page for now; section content will follow in a separate issue. Closes nebari-dev#120
killua156
force-pushed
the
docs/empty-structure
branch
from
ddf0587 to
754c4ea
Compare
jbouder
requested changes
Jun 9, 2026
jbouder
left a comment
jbouder
left a comment
Contributor
There was a problem hiding this comment.
A few things:
- Update the project for TypeScript
- The workflow looks to be a bit over-engineered.
Take a look at how things are done in nebi to support the above: https://github.com/nebari-dev/nebi/blob/main/.github/workflows/docs.yml
killua156
changed the title
killua156
changed the title
andrewfulton9
requested changes
Jun 10, 2026
andrewfulton9
left a comment
andrewfulton9
left a comment
Contributor
There was a problem hiding this comment.
A couple of comments, but otherwise looks good. I was able to build and serve it locally
Contributor
Author
|
Suggested changes made. |
- docusaurus.config.ts, sidebars.ts, tsconfig.json with typecheck script - Align deps with nebi: Docusaurus 3.10.1, React 19, @docusaurus/faster, @easyops-cn/docusaurus-search-local (drops the webpack pin workaround) - Switch yarn to npm (package-lock.json) - Replace deploy-docs.yml with nebi-style build-only docs.yml
OIDC trusted-publishing tokens are not issued to pull_request runs from forked repositories, so the publish step fails with 'missing ACTIONS_ID_TOKEN_REQUEST_URL'. Run it only for same-repo branches and tag pushes; uv build still validates the package on forks.
Contributor
Author
|
@jbouder could you please review this again and tell me if it looks good? I can then apply similar changes to all the other PRs i'm working on! |
Contributor
Author
|
@kcpevey please merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a placeholder landing page for the Nebari Chat Pack documentation. Content will be filled in a follow on issue.
Closes #120