Skip to content

ci(build-images): skip GPU and arm64 builds on PRs #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
viniciusdc wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci(build-images): skip GPU and arm64 builds on PRs #90

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .github/workflows/build-images.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,23 @@ concurrency:
cancel-in-progress: true

jobs:
# PR-time CI filtering:
# - GPU images (jupyterlab-gpu-base, jupyterlab-gpu) are skipped
# entirely on PRs — the same Dockerfile/pixi paths are exercised
# by the non-GPU variants, so PR cost should not pay for cuda
# base-image pulls and gpu builder runners.
# - linux/arm64 is skipped on PRs — amd64 build proves the pixi
# resolution; arm64 catches per-arch wheel gaps but rarely
# fails in isolation. Main builds full multi-arch.
# See issue #86 (section 3) for the audit that drove this.

jupyterlab-base:
name: "jupyterlab-base"
uses: ./.github/workflows/build-image.yaml
with:
image: nebari-data-science-pack-jupyterlab-base
target: jupyterlab-base
build_arm64: ${{ github.event_name != 'pull_request' }}
secrets:
QUAY_TOKEN: ${{ secrets.QUAY_TOKEN }}

Expand All @@ -43,11 +54,13 @@ jobs:
with:
image: nebari-data-science-pack-jupyterlab
target: jupyterlab
build_arm64: ${{ github.event_name != 'pull_request' }}
secrets:
QUAY_TOKEN: ${{ secrets.QUAY_TOKEN }}

jupyterlab-gpu-base:
name: "jupyterlab-gpu-base"
if: github.event_name != 'pull_request'
uses: ./.github/workflows/build-image.yaml
with:
image: nebari-data-science-pack-jupyterlab-gpu-base
Expand All @@ -60,6 +73,7 @@ jobs:

jupyterlab-gpu:
name: "jupyterlab-gpu"
if: github.event_name != 'pull_request'
uses: ./.github/workflows/build-image.yaml
with:
image: nebari-data-science-pack-jupyterlab-gpu
Expand All @@ -76,5 +90,6 @@ jobs:
with:
image: nebari-data-science-pack-jupyterhub
target: jupyterhub
build_arm64: ${{ github.event_name != 'pull_request' }}
secrets:
QUAY_TOKEN: ${{ secrets.QUAY_TOKEN }}
Loading