ci(docs): move docs workflow actions off the Node 20 runtime#128
Merged
Conversation
GitHub is deprecating the Node 20 action runtime. The docs workflow was the last one still on it; every other workflow already runs on Node 24. - Pin actions/checkout to v7.0.0 and actions/setup-node to v6.4.0, matching the SHA-pinned convention the other workflows use. - Bump cloudflare/wrangler-action to v4.0.0. The apiToken/accountId/ command inputs and the pages-deployment-alias-url output are unchanged. - Replace thollander/actions-comment-pull-request (no Node 24 release exists) with marocchino/sticky-pull-request-comment v3.0.5, which keeps the same sticky-per-PR preview comment via the header key.
|
📄 Docs preview for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
GitHub is deprecating the Node 20 action runtime. I audited every workflow and checked each action's
runs.using. All of them already run on Node 24 except the docs workflow, which had four actions still on Node 20:actions/checkout@v4actions/setup-node@v4cloudflare/wrangler-action@v3thollander/actions-comment-pull-request@v3Changes (docs.yml only)
v7.0.0and setup-node →v6.4.0, SHA-pinned to match the convention the other five workflows already use.v4.0.0. TheapiToken/accountId/commandinputs and thepages-deployment-alias-urloutput (used by the preview-comment step) are unchanged in v4, so behavior is the same.thollander/actions-comment-pull-requesthas no Node 24 release (latest v3.0.1 is still Node 20), so it's replaced withmarocchino/sticky-pull-request-comment@v3.0.5(Node 24). Theheader: docs-previewkey reproduces the previous sticky-per-PR dedup thatcomment-tagprovided, so the preview comment still updates in place instead of stacking.Verification
docs.ymlparses as valid YAML.checkout@v4/setup-node@v4/wrangler-action@v3/actions-comment-pull-requestrefs remain in any workflow.runs.usingisnode24and that every input/output this workflow relies on still exists at the pinned ref.The docs job will exercise all four updated actions (build + Cloudflare Pages deploy + preview comment) on this PR.