Skip to content

Use helm repo#21

Closed
andrewfulton9 wants to merge 3 commits into
nebari-dev:mainfrom
andrewfulton9:use_helm_repo
Closed

Use helm repo#21
andrewfulton9 wants to merge 3 commits into
nebari-dev:mainfrom
andrewfulton9:use_helm_repo

Conversation

@andrewfulton9

Copy link
Copy Markdown
Contributor

Reference Issues or PRs

#20

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

I used the workflow files with nebari-lgtm-pack, with some minor changes. It looks like it may be possible for the sync action to be run before the release is finished. There is a comment addressing this in the sync workflow

@andrewfulton9

Copy link
Copy Markdown
Contributor Author

Closing since now docs will be deployed on cloudflare pages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant