You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for your work on this @jbouder, everything looks great!
A couple of things I noticed:
Artifacts on UIs with borders: I noticed these artifacts on UI components that use a border interaction (focus, error). They disappear on zoom and scroll, and onloy seem to exist on a particular zoom level. Not sure if this is a reproducible bug or has something to do with my display settings.
Error states
The designs use a 1px stroke for error outlines, but seeing it in the storybook, I like the 2px focus border better. How do you feel about changing the error stroke weight to 2px?
Currently, the storybook only uses the red-border to signal an invalid / error state, however, that on its own is an a11y violation (WCAG 1.4.1: Use of Color says color can't be the only visual means of conveying information). That is why I added the error icon to the designs, to show a non-color cue for error. I know that there is a With Error variant, but if we are showing a separate Invalid variant in the storybook, it should be compliant on its own as well. We should either ship the Invalid state with the icon or with the error helper text.
Text area disabled state is currently resizeable: The disabled variant should not be resizeable at all. We can add a read-only variant if we want a no-input, resizeable text area component.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues or PRs
Fixes #28
What does this implement/fix?
Put a
xin the boxes that applyTesting
Documentation
Access-centered content checklist
Text styling
H1or#in markdown).Non-text content
Any other comments?