Skip to content

Discovery url fix#34

Merged
oren-openteams merged 2 commits into
nebari-dev:mainfrom
andrewfulton9:discoveryURL-fix
Jul 7, 2026
Merged

Discovery url fix#34
oren-openteams merged 2 commits into
nebari-dev:mainfrom
andrewfulton9:discoveryURL-fix

Conversation

@andrewfulton9

@andrewfulton9 andrewfulton9 commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Reference Issues or PRs

closes #18

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

@andrewfulton9

Copy link
Copy Markdown
Contributor Author

"Add to project" is failing because I opened it from a fork. Should I close this and reopen it from a repo branch?

@oren-openteams

Copy link
Copy Markdown
Contributor

Sorry for the delay. This PR is still needed and useful after the latest 0.1.1 release. The default helper matches what downstream deployments currently hardcode. Landing this would let those deployments drop their explicit auth.oidc.discoveryURL values in favor of the chart default. This is complementary to the pattern used on the Keycloak side which is to use KC_HOSTNAME_BACKCHANNEL_DYNAMIC=true (for split-horizon config), so nebi's OIDC discover stays entirely in-cluster and doesn't need to traverse egress proxies for backchannel calls. BTW we can ignore the add-to-project CI failure, that's a repo-side thing.

@oren-openteams

oren-openteams commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Tested this branch downstream on one of our deployments (via ArgoCD pointing at refs/pull/34/head, with the explicit auth.oidc.discoveryURL value removed from our helm values).

Result:

  • New helper renders exactly http://keycloak-keycloakx-http.keycloak.svc.cluster.local:8080/realms/nebari — identical to what we previously hardcoded, so behavior is unchanged.
  • Nebi pod initialized cleanly on the fresh render; log shows OIDC authentication enabled with the correct issuer URL.

Small request before merge: this branch is 5 commits behind main — notably missing #38 (orgCABundle.configMapName chart feature) and #39 (0.1.1 version bump). Would you mind rebasing on main before merge? Otherwise merging would revert those two features. Once rebased I'm +1 to merge.

@oren-openteams

Copy link
Copy Markdown
Contributor

Rebased on main for you — new tip is deee86b. The rebase was clean, no conflicts. Both original commits (first pass and follow data-science-pack paradigm) replayed identically on top of the 5 intervening main commits (#32 release, #33 CI, #38 orgCABundle, #39 0.1.1 bump, #41 rename).

Ready to merge from my side. Thanks for the fix!

@oren-openteams oren-openteams merged commit 0c1fad8 into nebari-dev:main Jul 7, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

discoveryURL example in values.yaml doesn't match nebari's actual Keycloak Service name

2 participants