Fix for an issue were -PdependencyLock.useGeneratedLock=true is ignored#113
Open
jotel wants to merge 1 commit intonebula-plugins:mainfrom
Open
Fix for an issue were -PdependencyLock.useGeneratedLock=true is ignored#113jotel wants to merge 1 commit intonebula-plugins:mainfrom
jotel wants to merge 1 commit intonebula-plugins:mainfrom
Conversation
…e flag didn't have any effect
This was referenced Jan 24, 2017
Author
|
Hey @rspieldenner @DanielThomas , any updates on this? ;) |
Member
|
Hi @jotel |
rpalcolea
force-pushed
the
main
branch
5 times, most recently
from
14d2949 to
ef876dc
Compare
rpalcolea
force-pushed
the
main
branch
2 times, most recently
from
425767b to
fd9e3e1
Compare
rpalcolea
force-pushed
the
main
branch
3 times, most recently
from
bc27559 to
6fe420a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like dependencyLock.useGeneratedLock didn't have any effect. Moreover the test code which covered that feature had invalid assertions which would be true even if the generated lock file wasn't used.
The proposed PR fixes the problem with properly constructing paths to locking files.
This also should fix this issue #84