show PLZ in agent organisation details for legacy agents#663
Open
nadavosa wants to merge 1 commit into
Open
Conversation
Load agentPostcode.postcode relation in the agent GET endpoint. When an agent has no address entity (legacy agents), fall back to the first agentPostcode PLZ so the org details section shows e.g. "14055 Berlin" instead of just "Berlin". Resolves need4deed-org/fe#627 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agentPostcode.postcodeto the relations loaded inGET /agents/:idagent.addressis null (legacy agents with no address entity), falls back to the firstagentPostcodePLZ to produce e.g."14055 Berlin"instead of"Berlin"addressentity continue to show the full"Street, PLZ Berlin"string viaserializeAddress— no change for thoseWhy
Legacy agents were created without an
Addressentity; their PLZ lives inagentPostcode. The org-details section was showing just "Berlin" for all such agents even when a postcode was available.Resolves need4deed-org/fe#627
Test plan
address = nullandagentPostcodeentries →agentDetails.addressshould be"14055 Berlin"(or whichever PLZ)address.street+address.postcode→ address unchanged, still"Heerstr. 110, 14055 Berlin""Berlin"🤖 Generated with Claude Code