fix: add 24h expiry to email verification/registration token#695
Open
nadavosa wants to merge 1 commit into
Open
fix: add 24h expiry to email verification/registration token#695nadavosa wants to merge 1 commit into
nadavosa wants to merge 1 commit into
Conversation
The verify JWT was signed without expiresIn, making it permanently valid. Now uses the existing VERIFY_LIFESPAN_MS constant (24h). Closes #651 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The verify JWT (
{ id, email, type: "verify" }) was signed withoutexpiresIn, making it valid indefinitely. A token embedded in a URL can leak via logs, referrer headers, or browser history — permanent validity was a security risk.Single change: pass
{ expiresIn: \${VERIFY_LIFESPAN_MS}` }(24 hours, the constant already defined inconfig/constants.ts) tojwt.signinsendEmailVerification`.Closes #651
Test plan
jwt.signis called withexpiresIn: "86400000"(24h in ms)authByVerifyTokenalready catches expired JWTs)🤖 Generated with Claude Code