Skip to content

feat: add phone number field to agent registration form#688

Merged
need4deed merged 1 commit into
developfrom
feat/676-phone-in-registration
Jun 17, 2026
Merged

feat: add phone number field to agent registration form#688
need4deed merged 1 commit into
developfrom
feat/676-phone-in-registration

Conversation

@nadavosa

Copy link
Copy Markdown
Collaborator

Summary

  • Adds required phone input to AccountStep after the confirm-password field
  • Validates minimum 7 characters (matches person.phone BE constraint)
  • Sends phone inside the person object on POST /user (already accepted by BE)
  • Adds agentRegistration.fields.phone and agentRegistration.errors.phoneTooShort keys to EN and DE translations

Closes #676
Depends on need4deed-org/be#685 (merged via BE PR #693)

Test plan

  • Fill registration form — phone field appears after "Confirm password"
  • Submit with empty phone — required error shown
  • Submit with phone shorter than 7 chars — too-short error shown
  • Submit with valid phone — user created, person.phone set in DB
  • German locale shows correct labels and error messages

🤖 Generated with Claude Code

Adds a required phone input to AccountStep after confirmPassword,
validates minimum 7 chars, and sends phone in person object on POST /user.

Closes #676

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@ivannissimrch ivannissimrch self-requested a review June 16, 2026 21:47

@ivannissimrch ivannissimrch left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it locally, and it works. The phone field appears after confirm-password; both the empty and under-7-character errors fire, and the German labels look correct. I also checked the DB, and the phone saves correctly for the person.

@need4deed need4deed merged commit 617fa75 into develop Jun 17, 2026
1 check passed
@need4deed need4deed deleted the feat/676-phone-in-registration branch June 17, 2026 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: add phone number field to agent registration form

3 participants