fix: read addressStreet/addressPostcode directly from API; show — when empty#691
Merged
Conversation
Now that BE PR #694 exposes addressStreet and addressPostcode in agentDetails, initialize the edit form from those fields instead of parsing the serialized address string. Display shows "—" when no address is set (BE no longer returns "Berlin" as a fallback). Closes #657 Depends on need4deed-org/be#694 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ApiAgentProfileGet.agentDetailsextended locally withaddressStreet?: string | nullandaddressPostcode?: string | null(mirrors fix: expose addressStreet and addressPostcode in agent GET; remove Berlin fallback be#694)OrganisationDetails.tsxnow initialises the edit form fromdetails.addressStreet/details.addressPostcodedirectly instead of callingparseAddress()on the serialised stringparseAddressremoved fromformatters.ts(no longer needed)"—"when address is empty (BE no longer returns"Berlin"as fallback)Closes #657
Depends on need4deed-org/be#694 (must be merged first)
Test plan
🤖 Generated with Claude Code