Skip to content

removes agent redirect for now#694

Merged
need4deed merged 3 commits into
developfrom
darrell/disable/ngo-redirect
Jun 17, 2026
Merged

removes agent redirect for now#694
need4deed merged 3 commits into
developfrom
darrell/disable/ngo-redirect

Conversation

@DarrellRoberts

Copy link
Copy Markdown
Collaborator

Description

Removes redirect when accessing /agents/[id]

Related Issues

Closes #ISSUE_ID (mandatory if applicable)

Changes

  • Bullet list of meaningful changes (optional)

Screenshots / Demos

If UI-related, add before/after or GIFs.

Checklist

  • WITHIN THE SCOPE OF AN ISSUE; No unnecessary files included
  • Tests added/updated
  • Documentation updated
  • CI passes

@DarrellRoberts DarrellRoberts self-assigned this Jun 17, 2026

@nadavosa nadavosa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Two sensible changes: removing the server-side role guard (client-side auth in profile sections handles visibility) and making the read-only table row navigable for NGO agents.

One issue to fix before merge:

AgentReadOnlyTableRow now has an onClick handler but $cursor is still "auto". This means no pointer cursor on hover, which makes the row feel non-interactive. Change to $cursor="pointer":

- <ClickableRow $isLast={isLast} $cursor={"auto"} data-testid={`agent-row-${id}`} onClick={handleGoToProfile}>
+ <ClickableRow $isLast={isLast} $cursor="pointer" data-testid={`agent-row-${id}`} onClick={handleGoToProfile}>

Minor notes:

  • PR description still has the placeholder #ISSUE_ID — worth linking the actual issue.
  • The "for now" in the title implies the redirect will come back. If the plan is to replace it with client-side auth (which the profile sections already handle via isAuthorized/isOwnProfile), consider noting that in the description so reviewers aren't left wondering.

@DarrellRoberts

Copy link
Copy Markdown
Collaborator Author

done, I've removed the Clickhandler like it was before. This prevents NGOs from clicking on other NGOs profiles

@need4deed need4deed merged commit 929ed35 into develop Jun 17, 2026
1 check passed
@need4deed need4deed deleted the darrell/disable/ngo-redirect branch June 17, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants