removes agent redirect for now#694
Merged
Merged
Conversation
nadavosa
reviewed
Jun 17, 2026
nadavosa
left a comment
Collaborator
There was a problem hiding this comment.
Review
Two sensible changes: removing the server-side role guard (client-side auth in profile sections handles visibility) and making the read-only table row navigable for NGO agents.
One issue to fix before merge:
AgentReadOnlyTableRow now has an onClick handler but $cursor is still "auto". This means no pointer cursor on hover, which makes the row feel non-interactive. Change to $cursor="pointer":
- <ClickableRow $isLast={isLast} $cursor={"auto"} data-testid={`agent-row-${id}`} onClick={handleGoToProfile}>
+ <ClickableRow $isLast={isLast} $cursor="pointer" data-testid={`agent-row-${id}`} onClick={handleGoToProfile}>Minor notes:
- PR description still has the placeholder
#ISSUE_ID— worth linking the actual issue. - The "for now" in the title implies the redirect will come back. If the plan is to replace it with client-side auth (which the profile sections already handle via
isAuthorized/isOwnProfile), consider noting that in the description so reviewers aren't left wondering.
Collaborator
Author
|
done, I've removed the Clickhandler like it was before. This prevents NGOs from clicking on other NGOs profiles |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes redirect when accessing
/agents/[id]Related Issues
Closes #ISSUE_ID (mandatory if applicable)
Changes
Screenshots / Demos
If UI-related, add before/after or GIFs.
Checklist