Skip to content

Faster compareDates function operating on numbers rather than Date ob… #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
androidi wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Faster compareDates function operating on numbers rather than Date ob… #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
719cae3
Faster compareDates function operating on numbers rather than Date ob…
androidi Dec 21, 2017
c5d55b6
Even faster compareDates by separating UTC offset from loop
androidi Dec 21, 2017
3f87a1a
Dist version compiled
androidi Dec 26, 2017
8ea14e0
Varying timezone fix
androidi Dec 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 18 additions & 9 deletions dist/calenstyle-core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3866,15 +3866,24 @@ CalenStyle.prototype = {
return iUnitDiff;
},

// Public Method
compareDates: function(dDate1, dDate2)
{
var to = this;
dDate1 = to._normalizeDateTime(dDate1, "START", "T");
dDate2 = to._normalizeDateTime(dDate2, "START", "T");
var iDateDiff = to.__getDifference("d", dDate1, dDate2);
return (iDateDiff === 0) ? iDateDiff: (iDateDiff/Math.abs(iDateDiff));
},
// Public Method
compareDates: function(dDate1, dDate2)
{
var to = this;

// Get timestamps as integers
var iTzOffset = dDate1.getTimezoneOffset() * 60000;
var tsD1 = dDate1.getTime() - iTzOffset;
var tsD2 = dDate2.getTime() - iTzOffset;

// Calculate offsets from 00:00:00 hh:mm:ss
var iOffD1 = tsD1 % $.CalenStyle.extra.iMS.d;
var iOffD2 = tsD2 % $.CalenStyle.extra.iMS.d;

// Calculate date difference
var iDiff = (tsD1 - iOffD1 - (tsD2 - iOffD2));
return Math.sign(iDiff / $.CalenStyle.extra.iMS.d);
},

// Public Method
compareDateTimes: function(dDate1, dDate2)
Expand Down
13 changes: 2 additions & 11 deletions dist/calenstyle-custom.min.js
View file
Open in desktop

Large diffs are not rendered by default.

29 changes: 19 additions & 10 deletions dist/calenstyle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* -----------------------------------------------------------------------------
/* -----------------------------------------------------------------------------

CalenStyle - Responsive Event Calendar
Version 2.0.8
Expand Down Expand Up @@ -3870,15 +3870,24 @@ CalenStyle.prototype = {
return iUnitDiff;
},

// Public Method
compareDates: function(dDate1, dDate2)
{
var to = this;
dDate1 = to._normalizeDateTime(dDate1, "START", "T");
dDate2 = to._normalizeDateTime(dDate2, "START", "T");
var iDateDiff = to.__getDifference("d", dDate1, dDate2);
return (iDateDiff === 0) ? iDateDiff: (iDateDiff/Math.abs(iDateDiff));
},
// Public Method
compareDates: function(dDate1, dDate2)
{
var to = this;

// Get timestamps as integers
var iTzOffset = dDate1.getTimezoneOffset() * 60000;
var tsD1 = dDate1.getTime() - iTzOffset;
var tsD2 = dDate2.getTime() - iTzOffset;

// Calculate offsets from 00:00:00 hh:mm:ss
var iOffD1 = tsD1 % $.CalenStyle.extra.iMS.d;
var iOffD2 = tsD2 % $.CalenStyle.extra.iMS.d;

// Calculate date difference
var iDiff = (tsD1 - iOffD1 - (tsD2 - iOffD2));
return Math.sign(iDiff / $.CalenStyle.extra.iMS.d);
},

// Public Method
compareDateTimes: function(dDate1, dDate2)
Expand Down
2 changes: 1 addition & 1 deletion dist/calenstyle.min.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 2 additions & 13 deletions dist/calenstyle.min.js
View file
Open in desktop

Large diffs are not rendered by default.

27 changes: 18 additions & 9 deletions src/calenstyle-core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3866,15 +3866,24 @@ CalenStyle.prototype = {
return iUnitDiff;
},

// Public Method
compareDates: function(dDate1, dDate2)
{
var to = this;
dDate1 = to._normalizeDateTime(dDate1, "START", "T");
dDate2 = to._normalizeDateTime(dDate2, "START", "T");
var iDateDiff = to.__getDifference("d", dDate1, dDate2);
return (iDateDiff === 0) ? iDateDiff: (iDateDiff/Math.abs(iDateDiff));
},
// Public Method
compareDates: function(dDate1, dDate2)
{
var to = this;

// Get timestamps as integers
var iTzOffset = dDate1.getTimezoneOffset() * 60000;
var tsD1 = dDate1.getTime() - iTzOffset;
var tsD2 = dDate2.getTime() - iTzOffset;

// Calculate offsets from 00:00:00 hh:mm:ss
var iOffD1 = tsD1 % $.CalenStyle.extra.iMS.d;
var iOffD2 = tsD2 % $.CalenStyle.extra.iMS.d;

// Calculate date difference
var iDiff = (tsD1 - iOffD1 - (tsD2 - iOffD2));
return Math.sign(iDiff / $.CalenStyle.extra.iMS.d);
},

// Public Method
compareDateTimes: function(dDate1, dDate2)
Expand Down
29 changes: 19 additions & 10 deletions src/calenstyle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* -----------------------------------------------------------------------------
/* -----------------------------------------------------------------------------

CalenStyle - Responsive Event Calendar
Version 2.0.8
Expand Down Expand Up @@ -3870,15 +3870,24 @@ CalenStyle.prototype = {
return iUnitDiff;
},

// Public Method
compareDates: function(dDate1, dDate2)
{
var to = this;
dDate1 = to._normalizeDateTime(dDate1, "START", "T");
dDate2 = to._normalizeDateTime(dDate2, "START", "T");
var iDateDiff = to.__getDifference("d", dDate1, dDate2);
return (iDateDiff === 0) ? iDateDiff: (iDateDiff/Math.abs(iDateDiff));
},
// Public Method
compareDates: function(dDate1, dDate2)
{
var to = this;

// Get timestamps as integers
var iTzOffset = dDate1.getTimezoneOffset() * 60000;
var tsD1 = dDate1.getTime() - iTzOffset;
var tsD2 = dDate2.getTime() - iTzOffset;

// Calculate offsets from 00:00:00 hh:mm:ss
var iOffD1 = tsD1 % $.CalenStyle.extra.iMS.d;
var iOffD2 = tsD2 % $.CalenStyle.extra.iMS.d;

// Calculate date difference
var iDiff = (tsD1 - iOffD1 - (tsD2 - iOffD2));
return Math.sign(iDiff / $.CalenStyle.extra.iMS.d);
},

// Public Method
compareDateTimes: function(dDate1, dDate2)
Expand Down