Skip to content

[Snyk] Upgrade middy from 0.25.1 to 0.36.0#766

Open
nejidevelops wants to merge 1 commit intomasterfrom
snyk-upgrade-a6b7b34b5b287faf6344ad9e2d8d4ad7
Open

[Snyk] Upgrade middy from 0.25.1 to 0.36.0#766
nejidevelops wants to merge 1 commit intomasterfrom
snyk-upgrade-a6b7b34b5b287faf6344ad9e2d8d4ad7

Conversation

@nejidevelops
Copy link
Owner

snyk-top-banner

Snyk has created this PR to upgrade middy from 0.25.1 to 0.36.0.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


  • The recommended version is 25 versions ahead of your current version.

  • The recommended version was released 6 years ago.

Issues fixed by the recommended upgrade:

Issue Score Exploit Maturity
high severity Prototype Pollution
SNYK-JS-AJV-584908
405 No Known Exploit
high severity Prototype Pollution
SNYK-JS-AWSSDK-1059424
405 Proof of Concept
high severity Asymmetric Resource Consumption (Amplification)
SNYK-JS-BODYPARSER-7926860
405 No Known Exploit
high severity Improper Verification of Cryptographic Signature
SNYK-JS-JWS-14188253
405 No Known Exploit
high severity Code Injection
SNYK-JS-LODASH-1040724
405 Proof of Concept
high severity Prototype Pollution
SNYK-JS-LODASH-450202
405 Proof of Concept
high severity Prototype Pollution
SNYK-JS-LODASH-567746
405 Proof of Concept
high severity Prototype Pollution
SNYK-JS-LODASH-608086
405 Proof of Concept
high severity Prototype Pollution
SNYK-JS-LODASH-6139239
405 Proof of Concept
high severity Allocation of Resources Without Limits or Throttling
SNYK-JS-QS-14724253
405 Proof of Concept
high severity Prototype Poisoning
SNYK-JS-QS-3153490
405 Proof of Concept
high severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-SEMVER-3247795
405 Proof of Concept
medium severity Prototype Pollution
SNYK-JS-XML2JS-5414874
405 Proof of Concept
medium severity Cross-site Scripting (XSS)
SNYK-JS-COOKIE-8163060
405 No Known Exploit
medium severity Open Redirect
SNYK-JS-EXPRESS-6474509
405 No Known Exploit
medium severity Cross-site Scripting
SNYK-JS-EXPRESS-7926867
405 No Known Exploit
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-LODASH-1018905
405 Proof of Concept
medium severity Prototype Pollution
SNYK-JS-LODASH-15053838
405 No Known Exploit
medium severity Prototype Pollution
SNYK-JS-MINDOCUMENT-13045385
405 Proof of Concept
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-PATHTOREGEXP-7925106
405 Proof of Concept
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-PATHTOREGEXP-8482416
405 Proof of Concept
low severity Cross-site Scripting
SNYK-JS-SEND-7926862
405 No Known Exploit
low severity Cross-site Scripting
SNYK-JS-SERVESTATIC-7926865
405 No Known Exploit
Release notes
Package name: middy
  • 0.36.0 - 2020-04-14
  • 0.35.0 - 2020-04-14
  • 0.34.0 - 2020-03-07
  • 0.33.2 - 2020-01-05
  • 0.33.1 - 2019-12-23
  • 0.33.0 - 2019-12-16
  • 0.32.3 - 2019-12-05
  • 0.32.2 - 2019-12-04
  • 0.32.1 - 2019-12-04
  • 0.32.0 - 2019-12-04
  • 0.30.5 - 2019-11-26
  • 0.30.4 - 2019-10-23
  • 0.30.3 - 2019-10-15
  • 0.30.2 - 2019-10-03
  • 0.30.1 - 2019-10-03
  • 0.29.0 - 2019-08-14
  • 0.28.5 - 2019-08-10
  • 0.28.4 - 2019-07-17
  • 0.28.3 - 2019-07-05
  • 0.28.2 - 2019-06-23
  • 0.28.1 - 2019-06-23
  • 0.28.0 - 2019-06-23
  • 0.27.1 - 2019-06-23
  • 0.27.0 - 2019-05-17
  • 0.26.0 - 2019-05-16
  • 0.25.1 - 2019-04-26
from middy GitHub release notes

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • This PR was automatically created by Snyk using the credentials of a real user.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

Snyk has created this PR to upgrade middy from 0.25.1 to 0.36.0.

See this package in npm:
middy

See this project in Snyk:
https://app.snyk.io/org/newtonombese1/project/1388f300-b8d2-4d58-a20b-7ec88f52e17d?utm_source=github&utm_medium=referral&page=upgrade-pr
@gemini-code-assist
Copy link

Summary of Changes

Hello @nejidevelops, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a crucial dependency update, specifically upgrading the middy library from version 0.25.1 to 0.36.0. The primary goal of this update is to bolster the project's security by resolving numerous identified vulnerabilities across several underlying packages. This proactive measure ensures the application remains robust and protected against known exploits.

Highlights

  • Dependency Upgrade: Upgraded the middy library from version 0.25.1 to 0.36.0, a jump of 25 versions, to ensure the project benefits from the latest features and stability improvements.
  • Security Vulnerability Resolution: This upgrade addresses a significant number of high, medium, and low severity security vulnerabilities, including various forms of Prototype Pollution, Code Injection, Asymmetric Resource Consumption, Improper Verification of Cryptographic Signature, Regular Expression Denial of Service (ReDoS), Cross-site Scripting (XSS), and Open Redirect.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • course-04/exercises/lesson-6/solution/package.json
    • Updated the middy dependency version from ^0.25.0 to ^0.36.0.
Activity
  • Snyk automatically created this pull request to upgrade the middy dependency to address reported vulnerabilities.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades middy from version 0.25.1 to 0.36.0, which is a valuable update for security. However, this upgrade includes significant breaking changes. The middy library restructured its middlewares into separate packages under the @middy scope starting from version 0.30.0. This will cause the application to fail as the existing code imports middlewares from a path that no longer exists. I've added a critical comment detailing the necessary code changes to adapt to this new version of middy.

"jimp": "^0.6.4",
"jsonwebtoken": "^8.5.1",
"middy": "^0.25.0",
"middy": "^0.36.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This upgrade to middy@0.36.0 introduces breaking changes that will cause the application to fail. Starting from v0.30.0, middy middlewares were moved to their own packages under the @middy scope (e.g., @middy/http-cors). The middy package at this version includes these as dependencies, but the import paths in your code must be updated.

Here are the required changes:

  1. In src/lambda/http/createImage.ts:

    • Change import { cors } from 'middy/middlewares' to import cors from '@middy/http-cors'. The cors middleware is now a default export.
  2. In src/lambda/auth/auth0Authorizer.ts:

    • Change import { secretsManager } from 'middy/middlewares' to import secretsManager from '@middy/secrets-manager'. The secretsManager middleware is now a default export.
  3. In both of the above files, and any other file using middy, it is recommended to change import * as middy from 'middy' to import middy from 'middy' as middy is now a default export.

Without these changes, the lambdas using middy will fail at runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants