Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion course-04/exercises/lesson-6/client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"dependencies": {
"@types/jest": "24.0.11",
"@types/node": "11.13.4",
"@types/react": "16.8.13",
"@types/react": "16.14.68",
"@types/react-dom": "16.8.4",
Comment on lines +8 to 9

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

To avoid potential type inconsistencies, the versions of @types/react and @types/react-dom should be kept in sync. Since @types/react is being upgraded, @types/react-dom should be upgraded as well.

It's also worth noting that your react and react-dom versions are ^16.8.6. Using type definitions for React 16.14 might cause other issues, which you may need to address separately.

Suggested change
"@types/react": "16.14.68",
"@types/react-dom": "16.8.4",
"@types/react": "16.14.68",
"@types/react-dom": "16.14.68",

"@types/react-router-dom": "^4.3.4",
"react": "^16.8.6",
Expand Down