Skip to content

[Snyk] Upgrade @types/react-dom from 16.8.4 to 16.9.25 #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nejidevelops wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Upgrade @types/react-dom from 16.8.4 to 16.9.25 #772

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion course-04/exercises/lesson-6/client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"@types/jest": "24.0.11",
"@types/node": "11.13.4",
"@types/react": "16.8.13",
"@types/react-dom": "16.8.4",
"@types/react-dom": "16.9.25",
Copy link

@gemini-code-assist gemini-code-assist bot Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The package-lock.json file has not been updated to reflect this dependency change. This is critical for ensuring consistent builds and that the security vulnerabilities are actually fixed. Please run npm install and commit the updated package-lock.json.

Copy link

@gemini-code-assist gemini-code-assist bot Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

There is a version mismatch between the upgraded @types/react-dom (16.9.25) and the react-dom dependency (16.8.6). This can lead to type inconsistencies and runtime errors. It's recommended to keep the versions of @types/* packages aligned with their corresponding libraries. Please consider upgrading react and react-dom to ^16.9.0 to resolve this.

"@types/react-router-dom": "^4.3.4",
"react": "^16.8.6",
"react-dom": "^16.8.6",
Expand Down