Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion course-04/exercises/lesson-6/client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "0.1.0",
"private": true,
"dependencies": {
"@types/jest": "24.0.11",
"@types/jest": "24.9.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This project uses react-scripts@2.1.8, which includes jest@23.6.0. The version of @types/jest should match the major version of jest for correct type definitions. This PR updates @types/jest to a newer v24 release, but it should be downgraded to a v23 release to match the Jest version used in the project. The latest v23 version is 23.3.14.

Suggested change
"@types/jest": "24.9.1",
"@types/jest": "^23.3.14",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Type definition packages like @types/jest are development-time dependencies and should be in devDependencies. This prevents them from being included in a production build, which can help reduce the bundle size. I recommend moving this and other @types/* packages from dependencies to devDependencies.

"@types/node": "11.13.4",
"@types/react": "16.8.13",
"@types/react-dom": "16.8.4",
Expand Down