FIx multi thread calls asyncWrite concurrently.#74
Open
g-xianhui wants to merge 2 commits intonekipelov:masterfrom
Open
FIx multi thread calls asyncWrite concurrently.#74g-xianhui wants to merge 2 commits intonekipelov:masterfrom
g-xianhui wants to merge 2 commits intonekipelov:masterfrom
Conversation
g-xianhui
commented
Mar 29, 2020
1. Thread A request quite a lot RedisAsyncClient::command, all the command post to RedisClientImpl::strand. 2. Thread B execute commands in strand one by one. The first asyncWrite swap dataWrited and dataQueued, so other doAsyncCommand won't enter asyncWrite. 3. the first asyncWrite call ends with a boost::asio::async_write, and left a later asyncWrite as handler. 4. boost::asio::async_write complete, thread C excute the handler asyncWrite, clear dataWrited. 5. Now thread B execute doAsyncCommand, and find dataWrited was empty, so it enters asyncWrite concurrently!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.