fix(aur): hash all six pdfapps-bin sources instead of SKIP#53
Merged
Conversation
Background: AUR user BluePeril reported that `updpkgsums` had to be run manually every time the pdfapps-bin PKGBUILD updated, because five of the six sources used `sha256sums = SKIP`. The auxiliary sources (LICENSE, .desktop, .metainfo.xml, icon, svg) are pinned to the release tag so technically immutable, but having real hashes makes `updpkgsums` a no-op and matches AUR conventions for binary packages. - Update committed `aur/pdfapps-bin/PKGBUILD` + `.SRCINFO` to v1.13.10 with sha256 of all six sources computed against the v1.13.10 tag. - Rewrite the `publish.yml` pdfapps-bin step to compute all six hashes on every release and rewrite the entire sha256sums block (Python in-place edit, both PKGBUILD and .SRCINFO). After this PR is merged, the next publish.yml run will push the v1.13.10 PKGBUILD to AUR with all six hashes, addressing the user's complaint. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AUR user BluePeril reported that `updpkgsums` had to be run manually every time the pdfapps-bin PKGBUILD updates, because five of the six sources used `sha256sums = SKIP`. The auxiliary sources (LICENSE, .desktop, .metainfo.xml, icon, svg) are pinned to the release tag and therefore immutable, but having real hashes makes `updpkgsums` a no-op and matches AUR conventions for binary packages.
Changes
How the new workflow patches files
Switched from `sed`-based single-hash replacement to a Python heredoc that:
Test plan
🤖 Generated with Claude Code